Footer and Events Page #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for asme-nitr ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
sidd233
requested changes
Jul 13, 2025
dist/assets/index-Dd617RC6.js
Outdated
Contributor
There was a problem hiding this comment.
in .gitignore, write 'dist' in a new line, this shouldn't be pushed to the repo
Contributor
There was a problem hiding this comment.
do not install any library, all the necessary libraries are provided, if you need specific library, ask in the group first
Contributor
There was a problem hiding this comment.
i think you meant to do this :
import { Outlet } from "react-router";
const Playground = () => {
return
<>
<div className="min-h-screen">
<Outlet />
</div>
<Footer />
</>;
};
export default Playground;
currently this is only returning the outlet
Contributor
There was a problem hiding this comment.
map everything from config files,
for example, instead of doing this:
<li>
<Link to="/about" className="hover:underline">
About us
</Link>
</li>
<li>
<Link to="/team" className="hover:underline">
Team
</Link>
</li>
<li>
<Link to="/events" className="hover:underline">
Events
</Link>
</li>
<li>
<Link to="/achievements" className="hover:underline">
Achievements
</Link>
</li>
<li>
<Link to="/gallery" className="hover:underline">
Gallery
</Link>
</li>
you can do this instead:
// make a file in config folder for this
const footerLinks = [
{
to : "/facebook"
text : "facebook"
}, ..... //make objects for each link
]
// and in this Footer.jsx file,
footerLinks.map((item,idx)=>{
<li>
<Link to={item.to} className="hover:underline">
{item.text}
</Link>
</li>
})
Updated playground.jsx and removed main layout page. Also incorporated separate event cards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.